chore(deps-dev): bump jsdom from 27.2.0 to 29.1.1#13790
Conversation
Bumps [jsdom](https://github.com/jsdom/jsdom) from 27.2.0 to 29.1.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v27.2.0...v29.1.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 29.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
left a comment
There was a problem hiding this comment.
Thanks @dependabot. Reviewed as maintainer.
Scope: dev-dependency bump of jsdom (the test DOM environment) from 27.2.0 to 29.1.1 — a major bump spanning two majors (27 → 29). Only package.json / pnpm-lock.yaml change; no production code is affected.
Concerns from the upstream release notes (v29.0.0):
- The CSSOM implementation was overhauled (the
@acemir/cssom+cssstyledeps were replaced with fresh internal implementations oncss-tree). Serialization/parsing/getComputedStyle()behavior changed in various edge cases — this is the most likely source of unit-test breakage for a DOM-heavy suite. - New minimum Node:
v22.13.0+for the v22 line. - Bad-port blocking was added per the fetch spec (could affect tests that fetch unusual ports).
- Dependabot flags a modified
prepareinstall script — worth noting but expected for jsdom.
The real gate is the test suite, and it is currently red:
build— failingcheck-tests-passed— failing- branch is CONFLICTING (DIRTY) — needs a rebase against the base branch.
So this cannot go in as-is. Please @dependabot rebase to resolve the conflict, and the failing build / unit-test jobs need to be investigated — given the jsdom CSSOM overhaul, the failures may well be real test breakage introduced by the major bump rather than flakes.
Changelog: n/a — dev-only dependency bump, no user-facing change, no changelog fragment required.
Not approving while CI is red and the branch has conflicts. Once it is rebased and all required checks are green, this can be re-reviewed.
Bumps jsdom from 27.2.0 to 29.1.1.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
9b9ea7e29.1.107efb78Optimize computed style comparison5f66329Fix background-origin/background-clip in background shorthandad8af77Fix border shorthand handling5a3e88e29.1.073db204Update dependencies and dev dependenciesa7168a5Support ratio CSS unit type15346e0Fix style cache invalidation2a1e2cd29.0.24097d66Resolve computed CSS values lazily in CSSStyleDeclarationMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for jsdom since your current version.
Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)